Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up accumulated vue warnings #1320

Closed
wants to merge 2 commits into from
Closed

chore: clean up accumulated vue warnings #1320

wants to merge 2 commits into from

Conversation

yanfali
Copy link
Collaborator

@yanfali yanfali commented Oct 28, 2023

Description

noroadsleft
noroadsleft reviewed Oct 28, 2023
View reviewed changes
src/components/Keycode.vue
Comment on lines +42 to +45
width: {
type: String,
default: undefined
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was width: null previously - is that no longer valid?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on L75 we check if it's undefined, so this is equivalent.

@yanfali
Copy link
Collaborator Author

yanfali commented Oct 29, 2023 via email

@yanfali yanfali closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanfali @noroadsleft