Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Legacy Magic Keycodes #1353

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

noroadsleft
Copy link
Member

Description

  • change LAG_SWP to AG_LSWP
  • change LAG_NRM to AG_LNRM
  • change RAG_SWP to AG_RSWP
  • change RAG_NRM to AG_RNRM
  • change GUI_ON to GU_ON
  • change GUI_OFF to GU_OFF
  • change LCG_SWP to CG_LSWP
  • change LCG_NRM to CG_LNRM
  • change RCG_SWP to CG_RSWP
  • change RCG_NRM to CG_RNRM

Fixes #1352.

- change `LAG_SWP` to `AG_LSWP`
- change `LAG_NRM` to `AG_LNRM`
- change `RAG_SWP` to `AG_RSWP`
- change `RAG_NRM` to `AG_RNRM`
- change `GUI_ON` to `GU_ON`
- change `GUI_OFF` to `GU_OFF`
- change `LCG_SWP` to `CG_LSWP`
- change `LCG_NRM` to `CG_LNRM`
- change `RCG_SWP` to `CG_RSWP`
- change `RCG_NRM` to `CG_RNRM`
Comment on lines +283 to +293
// Legacy
LAG_SWP: 'AG_LSWP',
LAG_NRM: 'AG_LNRM',
RAG_SWP: 'AG_RSWP',
RAG_NRM: 'AG_RNRM',
GUI_ON: 'GU_ON',
GUI_OFF: 'GU_OFF',
LCG_SWP: 'CG_LSWP',
LCG_NRM: 'CG_LNRM',
RCG_SWP: 'CG_RSWP',
RCG_NRM: 'CG_RNRM'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure where in the list I should put these, or how they should be marked.

@noroadsleft noroadsleft merged commit e63b404 into qmk:master Jun 30, 2024
2 checks passed
@noroadsleft noroadsleft deleted the update/magic_keycodes branch June 30, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Some magic keycodes are wrong (COMPILE ERROR)
2 participants