Remove axios #1369
Merged
Remove axios #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use await to flatten code - must await dispatch otherwise there's a race for the background updating correctly
yanfali
commented
Nov 1, 2024
| @@ -109,8 +112,7 @@ export default { | |||
| 'resizeConfig', | |||
| 'setLoadingKeymapPromise' | |||
| ]), | |||
| ...mapMutations('status', ['append']), | |||
| ...mapActions('status', ['scrollToEnd']), | |||
| ...pinia.mapActions(useStatusStore, ['append', 'scrollToEnd']), | |||
There was a problem hiding this comment.
I missed these actions in the last PR. So this fixes that.
yanfali
commented
Nov 2, 2024
| @@ -402,6 +402,9 @@ const mutations = { | |||
| }, | |||
| initKeymap(state, { layout, layer, code = 'KC_NO' }) { | |||
| const { name } = this.getters['keycodes/lookupKeycode'](code); | |||
| if (!layout) { | |||
There was a problem hiding this comment.
prevents a crash on initial load because layout is undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove Axios dependency and replace with standard baseline fetch.