Convert vuex/keycodes store to pinia #1370
Merged
+373
−299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- partial - values - no need to spread default exports
- replace all uses of vuex keycodes store with pinia - fix ergo keyboard menu
|
@precondition if you get a chance, a quick review or running it locally to spot if I broke anything would be appreciated. Thanks |
Some properties for typedefs are actually optional. Use the correct jsdoc syntax.
yanfali
commented
Nov 7, 2024
| @@ -1,12 +1,14 @@ | |||
| import Vue from 'vue'; | |||
| import random from 'lodash/random'; | |||
There was a problem hiding this comment.
remove a lot of dependencies on lodash, as a lot of this stuff is built in now
|
I added some jsdoc for some of the hairy parts, and documented some of the internal types used inside the keycode JSON. |
|
Oh shoot, I planned to take a look at this later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces all the uses of vuex keycodes store with a pinia equivalent. It also fixes a bug in the steno code I discovered while refactoring, where steno boards were not being identified correctly.
This should be 100% equivalent with no regressions.
Vuex is in deep maintenance mode and pinia is the recommended library for vue. This work is preparation for moving to vue 3 and vue 2 is now EOL.