fix: show the name instead of the code in print view #1371
Merged
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue [1363](#1363) Change the PrintKey to show the `.name` instead of the `.code` attribute because it's less human friendly. Remove some of the extraneous formatting around the element. This stems slightly from the different way we render Key components in the printing vs editing.
Before
After
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1363
Change the PrintKey to show the
.nameinstead of the.codeattribute because it's less human friendly. Remove some of the extraneous formatting around the element.This stems slightly from the different way we render Key components in the printing vs editing.
Description