Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add m2 keyboard. #19853

Open
wants to merge 95 commits into
base: master
Choose a base branch
from
Open

Add m2 keyboard. #19853

wants to merge 95 commits into from

Conversation

jonylee1986
Copy link
Contributor

@jonylee1986 jonylee1986 commented Feb 15, 2023

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added dependencies keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 15, 2023
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of all the custom code at the keyboard level and would rather see it removed entirely.

keyboards/hfdkb/m2/m2.c Outdated Show resolved Hide resolved
keyboards/hfdkb/m2/m2.c Outdated Show resolved Hide resolved
keyboards/hfdkb/m2/m2.c Outdated Show resolved Hide resolved
keyboards/hfdkb/m2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hfdkb/m2/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/hfdkb/m2/config.h Outdated Show resolved Hide resolved
keyboards/hfdkb/m2/config.h Outdated Show resolved Hide resolved
keyboards/hfdkb/m2/m2.c Outdated Show resolved Hide resolved
@vinorodrigues vinorodrigues mentioned this pull request Mar 2, 2023
14 tasks
keyboards/monsgeek/m2/config.h Outdated Show resolved Hide resolved
keyboards/monsgeek/m2/config.h Outdated Show resolved Hide resolved
keyboards/monsgeek/m2/config.h Outdated Show resolved Hide resolved
keyboards/monsgeek/m2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/monsgeek/m2/m2.c Outdated Show resolved Hide resolved
keyboards/monsgeek/m2/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/monsgeek/m2/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/monsgeek/m2/config.h Outdated Show resolved Hide resolved
keyboards/monsgeek/m2/config.h Outdated Show resolved Hide resolved
keyboards/monsgeek/m2/readme.md Outdated Show resolved Hide resolved
keyboards/monsgeek/m2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@tzarc
Copy link
Member

tzarc commented Aug 26, 2024

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

vinorodrigues
vinorodrigues approved these changes Sep 14, 2024
keyboards/monsgeek/m2/m2.c Outdated Show resolved Hide resolved
keyboards/monsgeek/m2/m2.c Outdated Show resolved Hide resolved
keyboards/monsgeek/m2/m2.c Outdated Show resolved Hide resolved
{"matrix": [2, 11], "x": 144, "y": 25, "flags": 4},
{"matrix": [2, 12], "x": 158, "y": 25, "flags": 4},
{"matrix": [2, 13], "x": 171, "y": 25, "flags": 1},
{"matrix": [2, 17], "x": 184, "y": 25, "flags": 1},
Copy link
Contributor

@vinorodrigues vinorodrigues Nov 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Numpad 7" key is flagged as LED_FLAG_MODIFIER

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants