Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cerberus to QMK #24226

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add Cerberus to QMK #24226

wants to merge 13 commits into from

Conversation

awkannan
Copy link
Contributor

@awkannan awkannan commented Aug 1, 2024

Description

Add Cerberus PCBs to QMK

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Aug 1, 2024

This is used for both the Solderable and Hotswap version of Cerberus

The hotswap PCB does not support per-key LEDs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this as well

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

Change some whitespace

Co-authored-by: Drashna Jaelre <[email protected]>
@awkannan
Copy link
Contributor Author

awkannan commented Oct 2, 2024

@drashna Ready on this one too

@drashna drashna requested a review from a team October 11, 2024 03:13
"knight": true,
"rainbow_mood": true,
"rainbow_swirl": true,
"rgb_test": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"rgb_test": true,

@awkannan
Copy link
Contributor Author

awkannan commented Nov 1, 2024

@fauxpark this one had the opposite problem compared to the others haha

I've fixed it and added in the RGB control keycodes.

Thanks! Ready for further review.

Comment on lines +3 to +10
"backlight": {
"breathing": true,
"levels": 6,
"pin": "A6"
},
"features": {
"backlight": true
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backlight config but no keycodes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just took care of this - thanks again for the catch.

Ready for review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants