-
-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cerberus to QMK #24226
base: master
Are you sure you want to change the base?
Add Cerberus to QMK #24226
Conversation
|
||
This is used for both the Solderable and Hotswap version of Cerberus | ||
|
||
The hotswap PCB does not support per-key LEDs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as #24227 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this as well
Co-authored-by: jack <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of August 26, 2024, qmk/qmk_firmware
is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.
As you've submitted a PR containing via
or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via
or VIA-enabled keymaps instead.
keyboards/cannonkeys/cerberus/solderable/keymaps/default/keymap.c
Outdated
Show resolved
Hide resolved
Change some whitespace Co-authored-by: Drashna Jaelre <[email protected]>
@drashna Ready on this one too |
"knight": true, | ||
"rainbow_mood": true, | ||
"rainbow_swirl": true, | ||
"rgb_test": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"rgb_test": true, |
@fauxpark this one had the opposite problem compared to the others haha I've fixed it and added in the RGB control keycodes. Thanks! Ready for further review. |
"backlight": { | ||
"breathing": true, | ||
"levels": 6, | ||
"pin": "A6" | ||
}, | ||
"features": { | ||
"backlight": true | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backlight config but no keycodes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just took care of this - thanks again for the catch.
Ready for review again.
Description
Add Cerberus PCBs to QMK
Types of Changes
Issues Fixed or Closed by This PR
Checklist