-
-
Notifications
You must be signed in to change notification settings - Fork 40.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Ploopy Classic, Mouse, and Thumb for RP2040 hardware upgrade #24880
base: develop
Are you sure you want to change the base?
Conversation
…/qmk_firmware into ploopyco/rp2040-updates
keyboards/ploopyco/mouse/rules.mk
Outdated
|
||
DEFAULT_FOLDER = ploopyco/mouse/rev1_003 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default folder is going away in the near future.
This file should probably be renamed to post_rules.mk
DEFAULT_FOLDER = ploopyco/mouse/rev1_003 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can rename it to post_rules.mk
. I can also rename keyboards/ploopyco/trackball_thumb/rules.mk
to keyboards/ploopyco/trackball_thumb/post_rules.mk
, if you think that makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the DEFAULT-FOLDER
lines caused a bunch of lint and CI failures. I added it back in with #f51e9f1 so that the lint and CI checks pass, but I'm open to reorganizing things if that's better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, if there is a rules.mk file, the build system (and CI) considers it to be a valid keyboard folder. In this case, .... it's not. Moving/renaming the file would probably be the best option.
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Description
The Ploopy Mouse, Thumb, and Classic are all being upgraded from their original MCU architecture (ATmega32u4) to a new MCU architecture (RP2040). These new firmwares have all been tested and are currently being distributed.
Types of Changes
Issues Fixed or Closed by This PR
Checklist