Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Ploopy Classic, Mouse, and Thumb for RP2040 hardware upgrade #24880

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

ploopyco
Copy link
Contributor

@ploopyco ploopyco commented Jan 29, 2025

Description

The Ploopy Mouse, Thumb, and Classic are all being upgraded from their original MCU architecture (ATmega32u4) to a new MCU architecture (RP2040). These new firmwares have all been tested and are currently being distributed.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr changed the base branch from master to develop January 29, 2025 17:07
keyboards/ploopyco/mouse/rev1_002/config.h Outdated Show resolved Hide resolved
keyboards/ploopyco/mouse/rev1_002/rules.mk Outdated Show resolved Hide resolved
Comment on lines 2 to 3

DEFAULT_FOLDER = ploopyco/mouse/rev1_003
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default folder is going away in the near future.

This file should probably be renamed to post_rules.mk

Suggested change
DEFAULT_FOLDER = ploopyco/mouse/rev1_003

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can rename it to post_rules.mk. I can also rename keyboards/ploopyco/trackball_thumb/rules.mk to keyboards/ploopyco/trackball_thumb/post_rules.mk, if you think that makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the DEFAULT-FOLDER lines caused a bunch of lint and CI failures. I added it back in with #f51e9f1 so that the lint and CI checks pass, but I'm open to reorganizing things if that's better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if there is a rules.mk file, the build system (and CI) considers it to be a valid keyboard folder. In this case, .... it's not. Moving/renaming the file would probably be the best option.

keyboards/ploopyco/trackball/rev1_004/config.h Outdated Show resolved Hide resolved
keyboards/ploopyco/trackball/rev1_004/rules.mk Outdated Show resolved Hide resolved
keyboards/ploopyco/trackball/rev1_005/config.h Outdated Show resolved Hide resolved
keyboards/ploopyco/trackball/rev1_005/rules.mk Outdated Show resolved Hide resolved
keyboards/ploopyco/trackball_thumb/rev1_001/config.h Outdated Show resolved Hide resolved
keyboards/ploopyco/trackball_thumb/rev1_001/rules.mk Outdated Show resolved Hide resolved
keyboards/ploopyco/trackball_thumb/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team February 2, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants