CompatHelper: bump compat for Adapt to 4, (keep existing compat) #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
compathelper/new_version/2023-12-19-01-21-32-070-03103789027
branch
from
b1bda8d
to
b2cabf0
Compare
|
we should probably set up some GPU tests as well for this. The julia GPU team provide some runners for this |
|
looking at the release notes for Adapt 4 and at our own code, nothing seems to have changed for us. I will proceed with merging this. I will make an issue to track the need for GPU CI tests. |
Krastanov
deleted the
compathelper/new_version/2023-12-19-01-21-32-070-03103789027
branch
|
oh, this was already done by #161 anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Adaptpackage from1, 2, 3.3to1, 2, 3.3, 4.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.