Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev-deps): bump Prettier related dependencies #565

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

vscav
Copy link
Member

@vscav vscav commented Sep 25, 2023

We want to bump prettier to v3.0.0. But the lint job on the current dependabot PR is failing, with: "prettier.resolveConfig.sync is not a function".

It happens for two reasons:

  • there is an incompatibility between prettier v3 and eslint-plugin-prettier v4 - so we need to bump eslint-plugin-prettier to v5.0.0 (latest)
  • in stylelint-prettier, support for prettier v3 support was added in v4.0.0 - so we need to bump stylelint-prettier to latest v4.0.2

And finally, because we need to bump stylelint-prettier to latest and because minimum supported stylelint version is now v15.8.0, we need to bump stylelint to latest v15.10.3.

@vscav vscav added the dependencies Pull requests that update a dependency file label Sep 25, 2023
@vscav vscav self-assigned this Sep 25, 2023
@vscav vscav changed the title chore(dev-deps): bump prettier related dependencies chore(dev-deps): bump Prettier related dependencies Sep 25, 2023
@vscav vscav marked this pull request as ready for review September 25, 2023 06:59
@vscav vscav merged commit 86e3b09 into master Sep 25, 2023
10 checks passed
@vscav vscav deleted the bump-prettier branch September 25, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants