Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add TypeScript configuration #432

Merged
merged 8 commits into from
Oct 2, 2023
Merged

feat: add TypeScript configuration #432

merged 8 commits into from
Oct 2, 2023

Conversation

dannycalleri
Copy link
Collaborator

@dannycalleri dannycalleri commented Sep 25, 2023 •
edited
Loading

👉 Best reviewed commit by commit.

This pull request adds support to TypeScript for both ember-autofocus-modifier and the test-app.

Related to qonto/ember-amount-input#543

@dannycalleri dannycalleri mentioned this pull request Sep 26, 2023
Merged
@dannycalleri dannycalleri force-pushed the typescript-setup branch 3 times, most recently from 5fdf2ef to d534d36 Compare September 27, 2023 13:30
@dannycalleri dannycalleri marked this pull request as ready for review September 27, 2023 15:05
@m-jovan m-jovan mentioned this pull request Sep 28, 2023
Merged
@dannycalleri dannycalleri force-pushed the typescript-setup branch 2 times, most recently from e549bc9 to 7e9e827 Compare September 28, 2023 14:30
vscav
vscav approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@vscav vscav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good to me 🔥 Nice job, thanks!
I did some "QA" - I just checked out your branch to ensure the type declaration files are well outputted during the addon build. And this is the case!

@dannycalleri dannycalleri merged commit 925ea22 into master Oct 2, 2023
@dannycalleri dannycalleri deleted the typescript-setup branch October 2, 2023 07:25
@vscav vscav changed the title Add TypeScript configuration feat: add TypeScript configuration Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vscav vscav vscav approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannycalleri @vscav