fix: end test waiter when using @AnimationData arg

test(test-app): add @AnimationData render smoke test
qonto · Apr 12, 2024 · ba1cb89 · ba1cb89
1 parent 144518e
commit ba1cb89
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 0 deletions.
diff --git a/ember-lottie/src/components/lottie.ts b/ember-lottie/src/components/lottie.ts
@@ -71,6 +71,7 @@ export default class LottieComponent extends Component<LottieSignature> {
 
     if (this.args.animationData) {
       animationData = this.args.animationData;
+      waiter.endAsync(token);
     } else if (this.args.path) {
       try {
         const response = await (this.args.fetchOptions

diff --git a/test-app/tests/integration/components/fixtures/data.ts b/test-app/tests/integration/components/fixtures/data.ts
diff --git a/test-app/tests/integration/components/lottie-test.ts b/test-app/tests/integration/components/lottie-test.ts
@@ -3,6 +3,7 @@ import { setupRenderingTest } from 'ember-qunit';
 import { clearRender, find, render } from '@ember/test-helpers';
 import { hbs } from 'ember-cli-htmlbars';
 import type { TestContext as TestContextBase } from '@ember/test-helpers';
+import exampleData from './fixtures/data';
 
 import window from 'ember-window-mock';
 import { setupWindowMock } from 'ember-window-mock/test-support';
@@ -11,6 +12,7 @@ import * as sinon from 'sinon';
 interface TestContext extends TestContextBase {
   onDataReady: () => void;
   fetchOptions: RequestInit;
+  exampleData?: Record<string, unknown>;
 }
 
 const NOOP = (): void => {};
@@ -44,6 +46,20 @@ module('Integration | Component | lottie', function (hooks) {
     assert.verifySteps(['data ready called']);
   });
 
+  test('it renders when using @animationData', async function (this: TestContext, assert) {
+    this.onDataReady = (): void => assert.step('data ready called');
+    this.exampleData = exampleData;
+
+    await render<TestContext>(hbs`
+      <Lottie
+        @animationData={{this.exampleData}}
+        @onDataReady={{this.onDataReady}}
+      />
+    `);
+    find('svg');
+    assert.verifySteps(['data ready called']);
+  });
+
   test('it calls window.matchMedia to check for prefers-reduced-motion', async function (this: TestContext, assert) {
     window.matchMedia = (mediaQuery): MediaQueryList => {
       assert.step(`matchMedia(${mediaQuery})`);