Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev-deps): remove ember-data from project #234

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

nicolasgasco
Copy link
Contributor

The aim of this PR is removing ember-data from this project, since it's not required for it.

@nicolasgasco nicolasgasco added the dependencies Pull requests that update a dependency file label Oct 10, 2023
@nicolasgasco nicolasgasco self-assigned this Oct 10, 2023
Copy link

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vscav vscav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@nicolasgasco nicolasgasco merged commit 64273e1 into main Oct 11, 2023
12 checks passed
@michelegera michelegera deleted the remove-ember-data branch December 18, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants