Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set body-max-line-length to Infinity #321

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

michelegera
Copy link
Contributor

@michelegera michelegera commented Dec 5, 2023

Since Dependabot commit messages body line lengths do not conform with commitlint’s current limit of 100 characters, we are modifying the rule to accept an infinite number of characters.

The reasons behind this:

  • Relying on the commit body from a third party is fragile; if Dependabot updates its wording, we have to update the override
  • Bumping to a fixed char limit is also not the best, could fail sometimes, we would be stuck (re-)bumping the limit every time
  • Commit body is actually not used in the changelog generation, so it won’t change much in the end

@michelegera michelegera self-assigned this Dec 5, 2023
commitlint.config.js Outdated Show resolved Hide resolved
@michelegera michelegera force-pushed the ignore-dependabot-commits branch from 924fa0f to 19e35c3 Compare December 6, 2023 11:37
@michelegera michelegera changed the title chore: ignore Dependabot commits Set body-max-line-length to Infinity Dec 6, 2023
@michelegera michelegera changed the title Set body-max-line-length to Infinity Set body-max-line-length to infinity Dec 6, 2023
@michelegera michelegera changed the title Set body-max-line-length to infinity Set body-max-line-length to Infinity Dec 6, 2023
@michelegera michelegera merged commit 7739259 into main Dec 6, 2023
17 checks passed
@michelegera michelegera deleted the ignore-dependabot-commits branch December 6, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants