Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
vmercierfr committed Apr 16, 2024
1 parent 7005c97 commit 3c2aca2
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 22 deletions.
40 changes: 20 additions & 20 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,26 +27,26 @@ jobs:
run: make build
- name: Run Go tests
run: make test
# - name: Code Coverage Report
# uses: irongut/[email protected]
# with:
# filename: coverage.xml
# badge: true
# fail_below_min: true
# format: markdown
# hide_branch_rate: false
# hide_complexity: true
# indicators: true
# output: both
# thresholds: '60 80'
# - uses: jwalton/gh-find-current-pr@v1
# id: finder
# - name: Add Coverage PR Comment
# uses: marocchino/sticky-pull-request-comment@v2
# with:
# number: ${{ steps.finder.outputs.pr }}
# path: code-coverage-results.md
# recreate: true
- name: Code Coverage Report
uses: irongut/[email protected]
with:
filename: coverage.xml
badge: true
fail_below_min: true
format: markdown
hide_branch_rate: false
hide_complexity: true
indicators: true
output: both
thresholds: '60 80'
- uses: jwalton/gh-find-current-pr@v1
id: finder
- name: Add Coverage PR Comment
uses: marocchino/sticky-pull-request-comment@v2
with:
number: ${{ steps.finder.outputs.pr }}
path: code-coverage-results.md
recreate: true

- name: Upload artifact
uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion internal/infra/postgresql/column_internal_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ func TestGetColumn(t *testing.T) {
Name: "my_column",
}

query := `SELECT data_type as columnType FROM information_schema.columns WHERE table_schema = \$1 AND table_name = \$2 AND column_name = \$3`
const query = `SELECT data_type as columnType FROM information_schema.columns WHERE table_schema = \$1 AND table_name = \$2 AND column_name = \$3`

mock, err := pgxmock.NewConn()
if err != nil {
Expand Down
3 changes: 2 additions & 1 deletion internal/infra/uuid7/uuid7.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"time"
)

//nolint:gomnd
func FromTime(timestamp time.Time) string {
// Convert timestamp to Unix time in milliseconds
unixMillis := timestamp.UnixNano() / int64(time.Millisecond)
Expand All @@ -28,7 +29,7 @@ func FromTime(timestamp time.Time) string {
}

// Combine time bytes and random bytes
uuidBytes := append(timeBytes, randomBytes...)
uuidBytes := append(timeBytes, randomBytes...) //nolint:gocritic,makezero

// Set the version byte (7 for UUIDv7, as a placeholder since we're doing a UUIDv7-like)
// Corrected to use the appropriate index after ensuring uuidBytes is 16 bytes
Expand Down

0 comments on commit 3c2aca2

Please sign in to comment.