Merge pull request #156 from qonto/disable-dashboards

Disable automatic dashboard deployment

README.md

@@ -120,7 +120,8 @@ It collects key metrics about:
 ## Dashboards
 
 > [!TIP]
-> Grafana dashboards are deployed by default as [GrafanaDashboard CRD](https://grafana.github.io/grafana-operator/docs/dashboards/) when Prometheus RDS exporter is deployed with Helm. If you deployed [Grafana operator](https://grafana.github.io/grafana-operator/) in your Kubernetes cluster, dashboards will be automatically imported and **maintained up-to-date**.
+> If you deploy [Grafana operator](https://grafana.github.io/grafana-operator/) in your Kubernetes cluster, dashboards could be automatically deployed and **maintained up-to-date**.
+> Set `dashboards.enabled: true` in your Helm deployment to deploy dashboards as [GrafanaDashboard CRD](https://grafana.github.io/grafana-operator/docs/dashboards/)
 
 <details>
   <summary>Why are we recommending Grafana operator?</summary>

configs/helm/tests/grafanadashboard_test.yaml

@@ -4,7 +4,13 @@ suite: grafana dashboard tests
 templates:
   - grafanadashboard.yaml
 tests:
+  - it: disable Grafana dashboards by default
+    asserts:
+      - hasDocuments:
+          count: 0
   - it: render default Grafana dashboards
+    values:
+      - ./values/with_grafanadashboards.yaml
     asserts:
       - isKind:
           of: GrafanaDashboard
@@ -33,7 +39,7 @@ tests:
           value: grafana
   - it: render custom Grafana dashboards settings
     values:
-      - ./values/with_grafanadashboards.yaml
+      - ./values/with_grafanadashboards_custom.yaml
     asserts:
       - equal:
           path: spec.resyncPeriod
@@ -44,9 +50,3 @@ tests:
       - equal:
           path: spec.instanceSelector.matchLabels.dashboards
           value: my-grafana
-  - it: disable Grafana dashboards
-    values:
-      - ./values/without_grafanadashboards.yaml
-    asserts:
-      - hasDocuments:
-          count: 0

configs/helm/tests/values/with_grafanadashboards.yaml

@@ -1,5 +1,3 @@
 ---
 dashboards:
-  resyncPeriod: 1m
-  instanceSelector: my-grafana
-  folderName: dmf
+  enabled: true

configs/helm/tests/values/with_grafanadashboards_custom.yaml

@@ -0,0 +1,6 @@
+---
+dashboards:
+  enabled: true
+  resyncPeriod: 1m
+  instanceSelector: my-grafana
+  folderName: dmf

configs/helm/values.yaml

@@ -86,7 +86,7 @@ tolerations: []
 affinity: {}
 
 dashboards:
-  enabled: true  # enabled GrafanaDashboard CRD import
+  enabled: false  # enabled GrafanaDashboard CRD import
   resyncPeriod: 24h  # how often the dashboard is refreshed
   instanceSelector: grafana  # selects Grafana for import
   folderName:  # folder assignment for dashboard