Rename metrics without units #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmercierfr
force-pushed
the
fix-values
branch
2 times, most recently
from
a250a5d to
b7a3b13
Compare
Closed
vmercierfr
force-pushed
the
fix-values
branch
from
b7a3b13 to
a5b0aaf
Compare
|
#sre |
vmercierfr
requested review from
dcupif,
chtitux,
qfritz,
victorboissiere and
airclovis
mcorbin
approved these changes
Nov 16, 2023
qfritz
reviewed
Nov 16, 2023
vmercierfr
force-pushed
the
fix-values
branch
2 times, most recently
from
edbaa7a to
24d4fdd
Compare
vmercierfr
force-pushed
the
fix-values
branch
from
24d4fdd to
fbcbba4
Compare
…ge_allocated_storage_bytes
…_replication_slot_disk_usage_bytes
vmercierfr
force-pushed
the
fix-values
branch
from
fbcbba4 to
475c3eb
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Specify units for
rds_replication_slot_disk_usage_averageandrds_usage_allocated_storage_averageWhy
According to Prometheus metrics best practices, these metrics should contain the
_bytessuffix instead of_averagerds_usage_allocated_storage_averagewas specified in Gigabytes while it should be in Bytes.How
rds_replication_slot_disk_usage_averagetords_replication_slot_disk_usage_bytesrds_usage_allocated_storage_averagetords_usage_allocated_storage_bytesIssue was reported by end-user in #32
Release plan