-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(metrics): Export RDS Certificate Authority attributes #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#sre |
vmercierfr
suggested changes
Nov 21, 2023
420fadb
to
80e0a53
Compare
vmercierfr
approved these changes
Nov 21, 2023
…ate_identifier label) in rds_instance_info The description of the possible values are documented on https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.SSL.html
This metric exposes the Unix timestamp of the expiration date of the instance certificate. This is different from the expiration of the root certificate of the chain, which may be in more than 10 years in the future. According to AWS documentation on https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.SSL-certificate-rotation.html , the certificate for instances that support certificate renewal without restart, such as RDS and Aurora, is renewed at half time. For those instances, the certificates is issued for 12 months. Hence, we should expect a new expiry timestamp every ~6 months, with a value not lower than now minus 6 months.
80e0a53
to
f729812
Compare
PR updated to include 2 commits : 1 for each attribute. |
Minimum allowed line rate is |
chtitux
added a commit
that referenced
this pull request
Dec 5, 2023
…ce_info metric in README description This label has been introduced in #38 , but README.md has not been updated with this new label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ca_certificate_identifier
attribute of therds_instance_info
metricrds_ca_certificate_valid_until
gauge.For the
rds-ca-2019
RDS CA, values are: