Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping AWS SDK updates #90

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Grouping AWS SDK updates #90

merged 4 commits into from
Dec 11, 2023

Conversation

vmercierfr
Copy link
Collaborator

@vmercierfr vmercierfr commented Dec 11, 2023

Objective

Grouping AWS SDK updates

Why

Dependabot created 26 PRs for AWS SDK updates we activated it a week ago.

screenshot 2023-12-11 at 09 39 22

AWS releases many patch versions for each AWS module. Because we are using several AWS modules (RDS, Cloudwatch, STS, ...), we are exposed to many PRs to review, which increases the maintenance cost.

Concurrent PRs on the AWS SDK packages also lead to Git conflicts on go.sum, which are waste to fix.

With this change, AWS SDK should be grouped once a week, like hashicorp/aws-sdk-go-base#842.

How

  • Group AWS SDK v2 update

Release plan

  • Merge this PR

@vmercierfr vmercierfr added the enhancement New feature or request label Dec 11, 2023
@vmercierfr vmercierfr requested review from chtitux and dcupif December 11, 2023 08:40
@vmercierfr
Copy link
Collaborator Author

#sre

@vmercierfr vmercierfr requested a review from mcorbin December 11, 2023 08:40
Copy link

Code Coverage

Package Line Rate Health
github.com/qonto/prometheus-rds-exporter/internal/app/cloudwatch 88%
github.com/qonto/prometheus-rds-exporter/internal/app/ec2 88%
github.com/qonto/prometheus-rds-exporter/internal/app/rds 80%
github.com/qonto/prometheus-rds-exporter/internal/app/servicequotas 51%
github.com/qonto/prometheus-rds-exporter/internal/app/unit 100%
Summary 82% (535 / 652)

Minimum allowed line rate is 60%

Copy link
Contributor

@dcupif dcupif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@vmercierfr vmercierfr merged commit 82cb05d into main Dec 11, 2023
8 checks passed
@vmercierfr vmercierfr deleted the dependabot-for-aws branch December 11, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants