Adjust the priority for egress enablement. First check namespace label then pod annotation. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l then pod annotation.
tylerflint
approved these changes
Nov 28, 2023
tylerflint
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that the pod label
qpoint-egress=enabledis set yet it needs to be disabled for a pod. Examples of this need can be seen for situations like https://docs.newrelic.com/docs/kubernetes-pixie/kubernetes-integration/troubleshooting/issues-with-istio/. This pull request makes it so that the namespace check is first and then pod check is done second and can override the namespace setting.