Feature: allow early script embedding #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some scripts need to be the very first thing loaded or they will no work. One example of this is the cookie consent script from Osano which will stop other scripts from setting cookies before they have consent from the visitor.
I previously introduced a change to add a custom stylesheet at the bottom of the page, but this was actually far more limiting that it needed to be. It only allowed the user to add their styles to a single stylesheed which is not great if they wish to add a third party stylesheet as well as their own styles. This change also makes this addition consistent with the other custom partial introduced in this pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes there. One to add an include at the top of the HTML
headtag so that the user can include scripts that need to be the first thing loaded.e.g. Osano or other cookie consent scripts which blocks the loading of other scripts until user consent has been given. This allows people to more easily comply with regulations in the EU.
This is just one example, but I'm sure there are many cases of scripts that should be loaded as early as possible.
The second change I made is just to make the previous inclusion of a custom stylesheets much more flexible and consistent with the change I made in the first commit.