Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5123][ADD] server_action_mass_edit #30

Closed
wants to merge 1 commit into from
Closed

[5123][ADD] server_action_mass_edit #30

wants to merge 1 commit into from

Conversation

nobuQuartile
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 5123-add-server_action_mass_edit branch from 8a4abfa to a4f35ad Compare January 24, 2025 07:37
@AungKoKoLin1997
Copy link
Contributor

This module is not compatible with auditlog and failed tests.
I have no quick solution and which was the root cause inside auditlog because there are 1000 lines of code for auditlog test cases and still not completely reviewed the code of auditlog.

@AungKoKoLin1997
Copy link
Contributor

@yostashiro @nobuQuartile Regarding the tests CI failed, I can't fix this error within a couple of hours because I am not familiar with auditlog and server_action_mass_edit and their design are not simple. So, can we get rid of this at the moment and come back later? Or we need to fix in this PR?

@yostashiro
Copy link
Member

@AungKoKoLin1997 Thanks for checking. We will drop this requirement for now, as it's not very important.

@yostashiro yostashiro closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nobuQuartile @AungKoKoLin1997 @yostashiro