-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recipes-bsp: libdmabufheap: Add recipe to compile libdmabufheap #766
base: master
Are you sure you want to change the base?
Conversation
1d39514
to
faa6960
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for the recipe being named qcom-libdmabufheap
instead of just libdmabufheap
?
There doesn't seem to be a versioned release tag. Please rename the recipe to foo_git.bb and set |
|
7a0ad80
to
a0f449f
Compare
This source code has some changes from qualcomm and is diverged from android open source libdmabufheap code, So it's being named with qcom-libdmabufheap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the unnecessary FILES
, what is the reason for the recipe being named qcom-libdmabufheap instead of just libdmabufheap ?
Also please drop the gerrit tag from the commit message |
And if it's a variant of an existing upstream project, there need to the appropriate (R)CONFLICTS /(R)REPLACES/(R)PROVIDES stanzas to alert the parser to the conflicts. |
Test jobs for commit a0f449f |
a0f449f
to
565c057
Compare
Add recipe to build libdmabuf which provices apis to access dmabuf heap framework. Signed-off-by: Vijayanand Jitta <[email protected]>
565c057
to
85e1c66
Compare
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Drop the
qcom-
prefix from the recipe name, everything in this layer is qcom-related. - Make it tested in the CI
In such a case, it might be better package libdmabufheap and add your patches on top of it. I strongly dislike the idea of qcom-specific forks of the existing projects. And qcom-specific recipes. |
Okay. After looking at the AOSP source... Don't package it. But the commit message should document that it's a fork of the AOSP library. Inside the recipe please add a brief comment describing Qualcomm changes, so that a random user browsing the repo tree would understand the difference and the reason. Please follow @koenkooi's suggestion and add 'PROVIDES' notes. |
Also, while I noticed it. Neither libdmabufheap nor libvmmem are |
Add recipe to compile libdmabuf which provices apis to access dmabuf heap framework.