Add bbappend for wpa-supplicant and hostapd #785
Conversation
miaoqing-quic
requested review from
quic-vkraleti,
ricardosalveti,
sbanerjee-quic and
ndechesne
as code owners
|
Generally we follow the OE commit message guidelines, so start with the recipe/class/conf and then say what it does and explain the how in the message body. So for this PR, the commit message should look like this:
and
|
| file://defconfig.qcom \ | ||
| " | ||
|
|
||
| SRCREV:qcom = "ad8d30e0a3601804c7464f53e54b1f4087364fd2" |
There was a problem hiding this comment.
This needs a comment why this specific revision was selected. It also needs a PV="x.y+git", since the version is different from the tarball based recipe.
|
|
||
| S:qcom = "${UNPACKDIR}/git" | ||
|
|
||
| SYSTEMD_SERVICE:${PN}:qcom = "" |
There was a problem hiding this comment.
This change isn't listed in the commit message and I'm fairly sure we shouldn't sabotage startup scripts like that. If we do, there needs to be a expansive comment in the recipe.
| install -m 0644 ${UNPACKDIR}/defconfig.qcom ${UNPACKDIR}/defconfig | ||
| } | ||
|
|
||
| do_install:qcom() { |
There was a problem hiding this comment.
Same as above: this change isn't listed in the commit message and I'm fairly sure we shouldn't sabotage startup scripts like that. If we do, there needs to be a expansive comment in the recipe.
| install -m 0644 ${UNPACKDIR}/defconfig.qcom ${UNPACKDIR}/defconfig | ||
| } | ||
|
|
||
| do_install:qcom() { |
There was a problem hiding this comment.
Same comment as the other commit: This change isn't listed in the commit message and I'm fairly sure we shouldn't sabotage startup scripts like that. If we do, there needs to be a expansive comment in the recipe.
And this also removes the dbus RPC configs.
|
Side note: hostapd is in meta-oe, which isn't enabled in our default build configs, so this will never get tested by the CI. |
Switch the code source from w1.fi/releases to w1.fi/hostap.git so that we can specify the latest code version. Additionally, enable features such as 11AX, 11BE, 11R, ACS and OWE.