Skip to content

readloop speedup #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

readloop speedup #10

wants to merge 2 commits into from

Conversation

toli-belo
Copy link

The old rw will error out on read() op so we don't need to recheck rw on each iteration

anatolii.belomestnov and others added 2 commits April 23, 2019 16:09
Remove extra rw checking and test it out
a465fcc 
The old rw will error out on read() op so we don't need to recheck rw on each iteration
@toli-belo
Add pooling of read buffer in worker
dea540e
@toli-belo
Copy link
Author

Note: not final PR yet, adding pooling of read buffer.

@toli-belo
Copy link
Author

This last speed up was great, please review

ssmccoy
ssmccoy requested changes May 10, 2019
View reviewed changes
Copy link
Collaborator

@ssmccoy ssmccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the use of bufio? it's only useful for files. Network connections have buffers already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssmccoy ssmccoy ssmccoy requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toli-belo @ssmccoy