Improve help text and error handling text for API form. #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually fixed merge conflicts in: modules/quant_api/src/Form/SettingsForm.php
kepol
added
documentation
steveworley
reviewed
Jun 16, 2023
| } | ||
| } | ||
|
|
||
| $form['api_endpoint'] = [ | ||
| '#type' => 'textfield', | ||
| '#title' => $this->t('API Endpoint'), | ||
| '#description' => $this->t('e.g: https://api.quantcdn.io'), | ||
| '#description' => $this->t('The fully-qualified domain name for the API endpoint, e.g. <code>https://api.quantcdn.io</code>'), |
There was a problem hiding this comment.
I think we should update this one so that the API endpoint is hardcoded and requires drush access to change 9/10 use cases will never need to change this value.
kepol
changed the title
kepol
changed the title
|
Updated based on Steve's feedback and added more info. |
kepol
changed the title
steveworley
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drupal.org issue: https://www.drupal.org/project/quantcdn/issues/3366596