changed back to should become visible async

quantori · Feb 21, 2024 · 0a2fc49 · 0a2fc49
1 parent cb2bf8d
commit 0a2fc49
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/Behavioral.Automation.Bindings.UI.Tests/Configurations/WebElement.cs b/Behavioral.Automation.Bindings.UI.Tests/Configurations/WebElement.cs
@@ -12,16 +12,16 @@ public class WebElement : IWebElement
     public ElementSelector ElementSelector { get; }
     public string? Description { get; set; }
 
-    public async Task IsVisibleAsync()
+    public async Task ShouldBecomeVisibleAsync()
     {
         // defaultDelay = 300 is just an example of idea that we will have default delay for all elements
         // and ability to specify delay in test steps if we have some taking time loading
         // (for example, because of data processing)
         var defaultDelay = 300;
-        await IsVisibleAsync(defaultDelay);
+        await ShouldBecomeVisibleAsync(defaultDelay);
     }
 
-    public async Task IsVisibleAsync(int delay)
+    public async Task ShouldBecomeVisibleAsync(int delay)
     {
         throw new NotImplementedException();
     }

diff --git a/Behavioral.Automation.Bindings.UI/Abstractions/IWebElement.cs b/Behavioral.Automation.Bindings.UI/Abstractions/IWebElement.cs
@@ -7,6 +7,6 @@ public interface IWebElement
     public WebContext WebContext { get; }
     public ElementSelector ElementSelector { get; }
     public string? Description { get; set; }
-    public Task IsVisibleAsync();
-    public Task IsVisibleAsync(int delay);
+    public Task ShouldBecomeVisibleAsync();
+    public Task ShouldBecomeVisibleAsync(int delay);
 }
diff --git a/Behavioral.Automation.Bindings.UI/Bindings/ButtonBindings.cs b/Behavioral.Automation.Bindings.UI/Bindings/ButtonBindings.cs
@@ -24,7 +24,7 @@ public async Task ClickOnButton(IButtonElement button)
     [Then(@"""(.+?)"" button should become visible")]
     public async Task ButtonShouldBecomeVisible(IButtonElement button)
     {
-        await button.IsVisibleAsync();
+        await button.ShouldBecomeVisibleAsync();
     }
 
     [When(@"user uploads ""(.*)"" file after clicking on ""(.*)"" button")]

diff --git a/Behavioral.Automation.Bindings.UI/Bindings/LabelBindings.cs b/Behavioral.Automation.Bindings.UI/Bindings/LabelBindings.cs
@@ -15,6 +15,6 @@ public async Task CheckLabelText(ILabelElement label, string text)
     [Then(@"""(.+?)"" label should become visible")]
     public async Task CheckLabelVisibility(ILabelElement label)
     {
-        await label.IsVisibleAsync();
+        await label.ShouldBecomeVisibleAsync();
     }
 }
diff --git a/Behavioral.Automation.Bindings.UI/Bindings/TableBinding.cs b/Behavioral.Automation.Bindings.UI/Bindings/TableBinding.cs
@@ -9,12 +9,12 @@ public class TableBinding
     [Then(@"""(.*)"" table should become visible$")]
     public async Task ThenTableShouldBecomeVisible(ITableWrapper table)
     {
-        await table.IsVisibleAsync();
+        await table.ShouldBecomeVisibleAsync();
     }
 
     [Then(@"""(.*)"" table should become visible within ""(.*)"" seconds")]
     public async Task ThenTableShouldBecomeVisible(ITableWrapper table, int seconds)
     {
-        await table.IsVisibleAsync(seconds);
+        await table.ShouldBecomeVisibleAsync(seconds);
     }
 }