Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparison in freeze_orbitals #898

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Fix comparison in freeze_orbitals #898

merged 2 commits into from
Jan 30, 2025

Conversation

aleksey-uvarov
Copy link
Contributor

Comparing using "is" instead of "==" would sometimes lead to incorrect results

@aleksey-uvarov
Fix comparison in freeze_orbitals
d3ff21d 
Comparing using "is" instead of "==" would sometimes lead to incorrect results
ncrubin
ncrubin approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@ncrubin ncrubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Seems like this is for an integer comparison where == is appropriate.

@mhucka mhucka enabled auto-merge (squash) January 30, 2025 06:15
@mhucka mhucka merged commit 64f203f into quantumlib:master Jan 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncrubin ncrubin ncrubin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleksey-uvarov @ncrubin @mhucka