Greedy topological sort of the binst graph to minimize qubit allocations / deallocations #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons / deallocations
mpharrigan
reviewed
Jul 1, 2024
| if TYPE_CHECKING: | ||
| from qualtran import BloqInstance | ||
|
|
||
| _INFINITY: int = int(1e18) |
There was a problem hiding this comment.
Eventually, I want to set _INFINITY + binst.i as the priority instead of _INFINITY; assuming we can make binst.i preserve insertion order following #1098
There was a problem hiding this comment.
In that case, a name other than "infinity" should be used if we're going to literally do "infinity + 1" as a meaningful distinction :p
mpharrigan
reviewed
Jul 1, 2024
anurudhp
reviewed
Jul 1, 2024
mpharrigan
reviewed
Jul 1, 2024
| goal to minimize qubit allocations and deallocations by pushing allocations to the | ||
| right and de-allocations to the left. | ||
| """ | ||
| yield from nx.lexicographical_topological_sort(binst_graph, key=_priority) |
There was a problem hiding this comment.
this function has slimmed down considerably! Thanks @anurudhp
mpharrigan
reviewed
Jul 1, 2024
| @@ -65,20 +65,20 @@ def test_qpic_data_for_reflect_using_prepare(): | |||
| reg_2 / \textrm{\scalebox{0.5}{QAny(2)}} | |||
| reg_3:on G:width=25:shape=box \textrm{\scalebox{0.8}{alloc}} | |||
| reg_3 / \textrm{\scalebox{0.5}{QAny(1)}} | |||
| selection G:width=121:shape=box \textrm{\scalebox{0.8}{StatePreparationAliasSampling}} reg G:width=37:shape=box \textrm{\scalebox{0.8}{sigma\_mu}} reg_1 G:width=17:shape=box \textrm{\scalebox{0.8}{alt}} reg_2 G:width=21:shape=box \textrm{\scalebox{0.8}{keep}} reg_3 G:width=65:shape=box \textrm{\scalebox{0.8}{less\_than\_equal}} | |||
There was a problem hiding this comment.
should we scrap this test? I guess it sortof forces you to look at the circuit so you can paste in the new data but it's not very DAMP https://testing.googleblog.com/2019/12/testing-on-toilet-tests-too-dry-make.html
mpharrigan
approved these changes
Jul 1, 2024
tanujkhattar
force-pushed
the
greedy_toposort
branch
from
76af1a7
to
45971d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new stable greedy topological sorting method and changes the default topological sort to use this method when iterating over nodes of a bloq instance graph.
This is useful to
Fixes the issue mentioned in #963 (comment), would be useful for #1097 and can be improved by addressing #1098