Relax restriction on classical inputs for modular addition to fix nightly CI #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
reviewed
Feb 3, 2025
| @@ -87,13 +87,15 @@ def signature(self) -> 'Signature': | |||
| def on_classical_vals( | |||
| self, x: 'ClassicalValT', y: 'ClassicalValT' | |||
| ) -> Dict[str, 'ClassicalValT']: | |||
| if not (0 <= x < self.mod): | |||
| # The construction still works when at most one of inputs equals `mod`. | |||
| special_case = (x == self.mod) ^ (y == self.mod) | |||
There was a problem hiding this comment.
can we use or instead of ^
There was a problem hiding this comment.
this is at most not at least ... although I can simply say not (x == y == self.mod) and update the inequalities below from x < mod to x <= mod, what do you prefer?
mpharrigan
approved these changes
Feb 3, 2025
|
but please wait until tomorrow to merge to see if I can receive notifications of failed nightly workflows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructions still work when at most one of their inputs
==mod. While this looks like a hack, this is necessarly since many higher level construction assume this sincex == modcan appear in lower level bloqs when the input to higher level bloq isx=0fixes the nightly CI & fixes #1525