Unary iteration: nth_operation_callgraph for more subclasses #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanujkhattar
requested changes
Apr 1, 2024
Comment on lines
+109
to
+111
| def nth_operation_callgraph(self, **selection_regs_name_to_val) -> Set['BloqCountT']: | ||
| selection_idx = tuple(selection_regs_name_to_val[reg.name] for reg in self.selection_regs) | ||
| return {(_cirq_gate_to_bloq(self.nth_gate(*selection_idx)), 1)} |
There was a problem hiding this comment.
The self.target_gate and self.nth_gate should be controlled gates here and below.
There was a problem hiding this comment.
I think this would be a good opportunity to revisit these gates, use the new controlled infrastructure, create a bloq example and fix whatever is failing.
|
This is a proof of principle for investigating #825. I'll make as draft and "contributions welcome" if someone wants to take this on fully |
|
Has this been done? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up gate counting from a couple seconds to a couple hundred milliseconds on the hubbard model example.