Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to not native x86 systems for external libraries #732

Merged
merged 8 commits into from
Apr 12, 2024
Merged

Adding support to not native x86 systems for external libraries #732

merged 8 commits into from
Apr 12, 2024

Conversation

mghibaudi
Copy link
Contributor

  • Filtering of x86 specific directive at both Makefile and setup.py level. Former needed for libraries that integrate Stim at the binary level (e.g. PyMatching).
  • Replacing sys with platform to gain access to additional information on the OS and CPU architecture.
  • Wrapped up with a function the extensions that shall be built for a specific architecture.

@Strilanc
Copy link
Collaborator

Is there a way to test these working, from github actions, so that I don't accidentally break them given that I'm running on x86 machines?

@Strilanc
Copy link
Collaborator

The new muxing logic is failing on widows and osx, as you can see in the CI tests.

@mghibaudi
Copy link
Contributor Author

Thanks @Strilanc for the quick review - enabled CI on the fork and debugged the issues (i386, i686 were missing - thus Win and Mac failures). Current version passes cleanly on my forkd' main.

@mghibaudi
Copy link
Contributor Author

@Strilanc - just checking did you manage to have a look at the latest changes? they do fix the previous error and pass in CI (on the forked branch).

@Strilanc Strilanc enabled auto-merge (squash) April 12, 2024 18:13
@Strilanc Strilanc merged commit f535af2 into quantumlib:main Apr 12, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants