Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in docs #620

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Fix typo in docs #620

merged 2 commits into from
Oct 20, 2023

Conversation

eliottrosenberg
Copy link
Contributor

No description provided.

@eliottrosenberg
Copy link
Contributor Author

eliottrosenberg commented Aug 19, 2023 •
edited
Loading

@95-martin-orion Do you know why this is failing Docker / Test on ubuntu-latest (pull_request)?

@95-martin-orion
Copy link
Collaborator

@95-martin-orion Do you know why this is failing Docker / Test on ubuntu-latest (pull_request)?

Seems to be from PEP 668, based on this SO question. The way we set up Docker-based CI tests is probably not consistent with modern best practices, and hasn't been updated in a long while - thus the CI decay.

@95-martin-orion 95-martin-orion mentioned this pull request Aug 21, 2023
Merged
@NoureldinYosri
Copy link
Collaborator

The CIs #624 #625 #627 have now been fixed

@eliottrosenberg
Copy link
Contributor Author

@NoureldinYosri @95-martin-orion Do you know why kokoro is taking so long to run?

@95-martin-orion 95-martin-orion added the kokoro:run Trigger Kokoro builds for this PR. label Oct 19, 2023
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Oct 19, 2023
@95-martin-orion
Copy link
Collaborator

@NoureldinYosri @95-martin-orion Do you know why kokoro is taking so long to run?

That's on me - Kokoro must be manually triggered by someone with write access to the repo applying the label. It should get started now.

@eliottrosenberg
Copy link
Contributor Author

@95-martin-orion Thanks! Would you be able to merge this? I don't have write access.

@95-martin-orion 95-martin-orion merged commit 1a7cab4 into quantumlib:master Oct 20, 2023
14 checks passed
@95-martin-orion
Copy link
Collaborator

Done. Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eliottrosenberg @95-martin-orion @NoureldinYosri @qsim-qsimh-bot