Clean up fox-in-a-hole #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dstrain115
commented
Jul 4, 2024
dstrain115
commented
- Add lots of comments and clean up some code paths
- Hopefully should make it easier to understand.
- Add lots of comments and clean up some code paths - Hopefully should make it easier to understand.
solodov
reviewed
Jul 16, 2024
| """ | ||
|
|
||
| def __init__(self, hole_nr=5, seed=None): | ||
| def __init__(self, number_of_holes: int = 5, seed: int = None): |
There was a problem hiding this comment.
seed: Optional[int] = None since default value is not an int
| self.state = self.hole_nr * [0.0] | ||
| index = self.rng.integers(low=0, high=self.hole_nr) | ||
| # All holes start as empty | ||
| self.state = self.number_of_holes * [0.0] |
There was a problem hiding this comment.
maybe that's just me, but [0.0] * self.number_of_holes reads better, intention of making a list of numbers of a certain size is clearer
| @@ -162,18 +247,25 @@ class QuantumGame(Game): | |||
| (QuantumWorld, [QuantumObject]) -> quantum world, list of holes | |||
| """ | |||
|
|
|||
| def __init__(self, hole_nr=5, iswap=False, qprob=0.5, seed=None): | |||
| def __init__(self, number_of_holes=5, iswap=False, qprob=0.5, seed=None): | |||
| for i, prob in enumerate(probs): | ||
| if prob > 0: | ||
| non_empty_holes.append(i) | ||
| non_empty_holes = [i for i in range(len(probs)) if probs[i] > 0] |
There was a problem hiding this comment.
list comprehension can be made nicer with [i for i, p in enumerate(probs) if p > 0]
solodov
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.