Make check/nbfmt more careful about tensorflow-docs #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user previously installed unitary in one virtual environment, did the `pip install -r requirements.txt`, ran `check/nbfmt` (which in turn installs `dev_tools/nbformat` and tensorflow-docs), then at a later time created a different virtual environment, did the same installation steps, and ran `check/nbfmt`, it would fail because the presence of `dev_tools/nbformat` fooled `nbfmt` into thinking tensorflow-docs was already installed. A solution is to decouple of check for the nbformat script and the tensorflow-docs package. I also tweaked the error-message rewriting code at the very end, because it wasn't doing the substitution in my environment. (That might be because the stock version of Bash on MacOS is an old 3.2.)
|
Note: the current CI check failures should disappear after PR #220 is applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user previously installed unitary in one virtual environment, did the
pip install -r requirements.txt, rancheck/nbfmt(which in turn installsdev_tools/nbformatand tensorflow-docs), then at a later time created a different virtual environment, did the same installation steps, and rancheck/nbfmt, it would fail because the presence ofdev_tools/nbformatfoolednbfmtinto thinking tensorflow-docs was already installed. A solution is to decouple of check for the nbformat script and the tensorflow-docs package.I also tweaked the error-message rewriting code at the very end, because it wasn't doing the substitution in my environment. (That might be because the stock version of Bash on MacOS is an old 3.2.)