Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-generated code against v1.30.0 #95

Merged
merged 7 commits into from
Apr 22, 2024
Merged

re-generated code against v1.30.0 #95

merged 7 commits into from
Apr 22, 2024

Conversation

garethahealy
Copy link
Contributor

  • re-generated code against v1.30.0
  • updated actions to latest due to most running on deprecated node versions
  • updated generate script to work within ci correctly and added ci to call it to validate it works correctly
  • fixed macos build issue due to 2 files with different case

#94

@garethahealy garethahealy requested a review from a team as a code owner April 18, 2024 18:47
@garethahealy
Copy link
Contributor Author

@gastaldi @iocanel can you review please

@sachin-bagla can you test this PR to see if it resolves your issue please

@garethahealy
Copy link
Contributor Author

CI test io.quarkiverse.quarkus.authzed.client.test.DevServicesAuthzedClientTest.shouldAccessDashboard has been failing for past few months from PR history.

@garethahealy
Copy link
Contributor Author

re-enabled metrics and http tests. dashboard is no longer supported on the image, so removed test:

Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachin-bagla
Copy link

sachin-bagla commented Apr 22, 2024

@gastaldi @iocanel can you review please

@sachin-bagla can you test this PR to see if it resolves your issue please

Thanks for looking into this @garethahealy
I have cloned your repo in local and build quarkus-authzed-client-deployment-1.0.0-SNAPSHOT.jar locally from your repo and able see both fields (limit, cursor) in quarkus-authzed-client-deployment-1.0.0-SNAPSHOT.jar. Please let me know once you release latest version for this.

@iocanel
Copy link
Contributor

iocanel commented Apr 22, 2024

@garethahealy: Thanks a ton for this. Can you please address the conflicts so that we can merge?

@garethahealy
Copy link
Contributor Author

@iocanel ; i dont see any conflicts highlighted...
Screenshot 2024-04-22 at 09 01 21

@iocanel
Copy link
Contributor

iocanel commented Apr 22, 2024

I am seeing this:
2024-04-22_11:21:18_1689x828

But when I select Create a merge commit I am seeing exactly what you see. Anyway, I'll do that instead.

@iocanel iocanel merged commit c6d77b7 into quarkiverse:main Apr 22, 2024
2 checks passed
@sachin-bagla
Copy link

@garethahealy Thanks for fixing this. I see PR is merged now. Which is latest official quarkus-authzed-client release version.
I still seeing 0.3.0 is latest one https://repo.maven.apache.org/maven2/io/quarkiverse/authzed/quarkus-authzed-client/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants