Allow disabled the secret manager

quarkiverse · Sep 11, 2023 · a012db8 · a012db8
1 parent e2dc8c9
commit a012db8
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/...me/src/main/java/io/quarkiverse/googlecloudservices/common/GcpBootstrapConfiguration.java b/...me/src/main/java/io/quarkiverse/googlecloudservices/common/GcpBootstrapConfiguration.java
@@ -52,4 +52,10 @@ public interface GcpBootstrapConfiguration {
      */
     @WithDefault("true")
     boolean accessTokenEnabled();
+
+    /**
+     * Whether to enable the secret manager
+     */
+    @WithDefault("true")
+    boolean secretManagerEnabled();
 }
diff --git a/integration-tests/main/src/main/resources/application.properties b/integration-tests/main/src/main/resources/application.properties
@@ -17,7 +17,9 @@
 
 # Secret Manager Demo
 # You can load secrets from Google Cloud Secret Manager with the ${sm//<SECRET_ID>} syntax.
-my.database.password=${sm//integration-test}
+%prod.my.database.password=${sm//integration-test}
+%test.my.database.password=test
+%test.quarkus.google.cloud.secret-manager-enabled=false
 
 ## Logging config
 %dev.quarkus.google.cloud.logging.enabled=false

diff --git a/...arkiverse/googlecloudservices/secretmanager/runtime/config/SecretManagerConfigSource.java b/...arkiverse/googlecloudservices/secretmanager/runtime/config/SecretManagerConfigSource.java
@@ -9,6 +9,7 @@
 import java.util.Set;
 import java.util.concurrent.atomic.AtomicBoolean;
 
+import com.google.api.gax.core.FixedCredentialsProvider;
 import com.google.auth.oauth2.GoogleCredentials;
 import com.google.cloud.secretmanager.v1.AccessSecretVersionResponse;
 import com.google.cloud.secretmanager.v1.SecretManagerServiceClient;
@@ -32,8 +33,13 @@ public class SecretManagerConfigSource extends AbstractConfigSource {
     public SecretManagerConfigSource(final GcpBootstrapConfiguration gcpConfig, final String projectId) {
         super(CONFIG_SOURCE_NAME, SECRET_MANAGER_ORDINAL);
         this.projectId = projectId;
-        this.client = createClient(gcpConfig, projectId);
-        this.closed = new AtomicBoolean(false);
+        if (gcpConfig.secretManagerEnabled()) {
+            this.client = createClient(gcpConfig, projectId);
+            this.closed = new AtomicBoolean(false);
+        } else {
+            this.client = null;
+            this.closed = new AtomicBoolean(true);
+        }
     }
 
     @Override
@@ -75,7 +81,7 @@ private static SecretManagerServiceClient createClient(
             return SecretManagerServiceClient.create(
                     SecretManagerServiceSettings.newBuilder()
                             .setQuotaProjectId(projectId)
-                            .setCredentialsProvider(() -> credentials(gcpConfig))
+                            .setCredentialsProvider(FixedCredentialsProvider.create(credentials(gcpConfig)))
                             .build());
         } catch (IOException e) {
             throw new RuntimeException(e);