Prevent the usage of OpenTelemetry in GcpDefaultsConfigSourceFactory #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because GcpDefaultsConfigSourceFactory is called very early in the application startup and can thus mess up the OpenTelemetry configuration performed later by Quarkus Fixes: quarkusio/quarkus#35500
brunobat
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
This seems to be the same fix used in quarkusio/quarkus#22864
for the Google client.
|
@all-contributors please add @geoand for code |
|
I've put up a pull request to add @geoand! 🎉 |
|
@loicmathieu could you cut a release so that we have one fully compatible with 3.3? |
|
@gsmet yes, I'll do it today if I find the time. |
|
Sorry, but this still happens w/ 3.3.1 (via the platform-bom). Reproducer in this manually updated PR (use Edit: quarkiverse/googlecloudservices 2.4.0 is being used |
|
The odd thing is that I can't reproduce the problem in the integration tests of this module... In any case, we might also need to set the |
|
Please doublecheck if the opensensus-shim lib is aligned with OTel 1.28.0... The error lines don't precisely match the current code. This forces the static init of the OTel SDK before we bootstrap the Quarkus SDK... This seems the same problem we had to solve with the JDBC drivers instrumentation. |
|
The opencensus shim is at 1.28.0-alpha (via the Quarkus platform bom). |
|
(Just thinking loud:)
Maybe it's feasible to copy the code to get the default project ID but use another HTTP client, because that seems to be the thing that implicitly creates the "offending" global tracer. I don't see an option to tell the Google HTTP client to omit tracing for a particular request. |
|
An ugly workaround could be to call I'm not sure whether it could work to always return a single |
Setting the System Property I mentioned above should avoid the need for this |
|
@geoand if I understand it correctly, we need to set |
|
But I have not tested it, I just think it will help just by looking at the code |
snazy
added a commit
to snazy/quarkus-google-cloud-services
that referenced
this pull request
Sep 14, 2023
As described in [this issue](quarkusio/quarkus#35500), Quarkus w/ the Google clooud services and OpenCensus shim does not startup due to a static initialization issue. `com.google.cloud.ServiceOptions` is used by the extension to get the Google cloud default-project-ID, which uses Google's HTTP client, which uses OpenCensus, which triggers an initialization of OpenTelemetry, which conflicts with the OTel init from Quarkus. This change updates `GcpDefaultsConfigSourceFactory` to use Java's HTTP client. See also quarkiverse#487, the alternatives mentioned in [this comment](quarkiverse#487 (comment)) to implement a `ConfigSource` and in [this comment](quarkiverse#487 (comment)) to set `otel.java.global-autoconfigure.enabled=false)` end in the same OpenCensus/OpenTracing init race. Fixes quarkusio/quarkus#35500
snazy
added a commit
to snazy/quarkus-google-cloud-services
that referenced
this pull request
Sep 14, 2023
As described in [this issue](quarkusio/quarkus#35500), Quarkus w/ the Google clooud services and OpenCensus shim does not startup due to a static initialization issue. `com.google.cloud.ServiceOptions` is used by the extension to get the Google cloud default-project-ID, which uses Google's HTTP client, which uses OpenCensus, which triggers an initialization of OpenTelemetry, which conflicts with the OTel init from Quarkus. This change updates `GcpDefaultsConfigSourceFactory` to use Java's HTTP client. See also quarkiverse#487, the alternatives mentioned in [this comment](quarkiverse#487 (comment)) to implement a `ConfigSource` and in [this comment](quarkiverse#487 (comment)) to set `otel.java.global-autoconfigure.enabled=false)` end in the same OpenCensus/OpenTracing init race. Fixes quarkusio/quarkus#35500
snazy
added a commit
to snazy/quarkus-google-cloud-services
that referenced
this pull request
Sep 14, 2023
As described in [this issue](quarkusio/quarkus#35500), Quarkus w/ the Google clooud services and OpenCensus shim does not startup due to a static initialization issue. `com.google.cloud.ServiceOptions` is used by the extension to get the Google cloud default-project-ID, which uses Google's HTTP client, which uses OpenCensus, which triggers an initialization of OpenTelemetry, which conflicts with the OTel init from Quarkus. This change updates `GcpDefaultsConfigSourceFactory` to use Java's HTTP client. See also quarkiverse#487, the alternatives mentioned in [this comment](quarkiverse#487 (comment)) to implement a `ConfigSource` and in [this comment](quarkiverse#487 (comment)) to set `otel.java.global-autoconfigure.enabled=false)` end in the same OpenCensus/OpenTracing init race. Fixes quarkusio/quarkus#35500
snazy
added a commit
to snazy/quarkus-google-cloud-services
that referenced
this pull request
Sep 18, 2023
As described in [this issue](quarkusio/quarkus#35500), Quarkus w/ the Google clooud services and OpenCensus shim does not startup due to a static initialization issue. `com.google.cloud.ServiceOptions` is used by the extension to get the Google cloud default-project-ID, which uses Google's HTTP client, which uses OpenCensus, which triggers an initialization of OpenTelemetry, which conflicts with the OTel init from Quarkus. This change updates `GcpDefaultsConfigSourceFactory` to use Java's HTTP client. See also quarkiverse#487, the alternatives mentioned in [this comment](quarkiverse#487 (comment)) to implement a `ConfigSource` and in [this comment](quarkiverse#487 (comment)) to set `otel.java.global-autoconfigure.enabled=false)` end in the same OpenCensus/OpenTracing init race. Fixes quarkusio/quarkus#35500
snazy
added a commit
to snazy/quarkus-google-cloud-services
that referenced
this pull request
Sep 18, 2023
As described in [this issue](quarkusio/quarkus#35500), Quarkus w/ the Google clooud services and OpenCensus shim does not startup due to a static initialization issue. `com.google.cloud.ServiceOptions` is used by the extension to get the Google cloud default-project-ID, which uses Google's HTTP client, which uses OpenCensus, which triggers an initialization of OpenTelemetry, which conflicts with the OTel init from Quarkus. This change updates `GcpDefaultsConfigSourceFactory` to use Java's HTTP client. See also quarkiverse#487, the alternatives mentioned in [this comment](quarkiverse#487 (comment)) to implement a `ConfigSource` and in [this comment](quarkiverse#487 (comment)) to set `otel.java.global-autoconfigure.enabled=false)` end in the same OpenCensus/OpenTracing init race. Fixes quarkusio/quarkus#35500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because GcpDefaultsConfigSourceFactory is called very early in the application startup
and can thus mess up the OpenTelemetry configuration performed later by Quarkus
Fixes: quarkusio/quarkus#35500
P.S. This pattern is also used in Quarkus code here.