Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use CDI beans to read the SM #493

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Do not use CDI beans to read the SM #493

merged 2 commits into from
Sep 11, 2023

Conversation

radcortez
Copy link
Contributor

@radcortez radcortez mentioned this pull request Sep 6, 2023
Closed
loicmathieu
loicmathieu requested changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, it will open a second client which scope is linked to the scope of the config object?

.../quarkiverse/googlecloudservices/secretmanager/runtime/config/SecretManagerConfigSource.java Show resolved Hide resolved
@radcortez
Copy link
Contributor Author

As I understand it, it will open a second client which scope is linked to the scope of the config object?

Correct.

@loicmathieu loicmathieu merged commit e2dc8c9 into quarkiverse:main Sep 11, 2023
1 check failed
@loicmathieu
Copy link
Collaborator

Superseded by #499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No longer possible to use secret-manager injected secret in @ConfigMapping class
2 participants
@radcortez @loicmathieu