Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a11y-base version to avoid dependency convergence issue #495

Merged

Conversation

loicmathieu
Copy link
Collaborator

No description provided.

@loicmathieu loicmathieu merged commit 915f572 into quarkiverse:main Sep 8, 2023
1 check passed
@loicmathieu loicmathieu deleted the fix/dependency-convergence branch September 8, 2023 11:37
@gsmet
Copy link
Member

gsmet commented Sep 8, 2023

You shouldn't need to do this at your level I think.

@phillip-kruger told me it was fixed in recent version and for latest 3.3, I think I ended up adding the dependency in the BOM.

With which version do you have this issue?

@loicmathieu
Copy link
Collaborator Author

There were ecosystem CI failures.

There is other issues with 3.4 that I need to sort out, I'll remove the dependency convergence when doing the 3.4 migration.

@gsmet
Copy link
Member

gsmet commented Sep 8, 2023

I wouldn't expect problems with main as @phillip-kruger told me this was fixed. @phillip-kruger can you confirm?

@phillip-kruger
Copy link
Member

Yes main should be fixed

@loicmathieu
Copy link
Collaborator Author

I removed it and upgrade to Quarkus 3.4.0.CR1, everything works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants