Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(devservices): added bigtable dev service #504

Merged
merged 5 commits into from
Sep 18, 2023

Conversation

zZHorizonZz
Copy link
Contributor

This PR adds devservice for bigtable. Similar to firstore or pubsub emulators.

@zZHorizonZz
Copy link
Contributor Author

zZHorizonZz commented Sep 15, 2023

I'm now wondering, Is there a reason why there isn't a Bigtable/admin client producer?

Copy link
Collaborator

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot

@loicmathieu
Copy link
Collaborator

I'm now wondering, Is there a reason why there isn't a Bigtable/admin client producer?

At the time being, it was because there is not a single client but multiple ones.
I think adding a producer for the client would be a good addition.

@loicmathieu loicmathieu merged commit edb487e into quarkiverse:main Sep 18, 2023
1 check passed
@zZHorizonZz
Copy link
Contributor Author

At the time being, it was because there is not a single client but multiple ones. I think adding a producer for the client would be a good addition.

OK then I will try to look into it and with it, I will also add the documentation for this devservice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants