Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert BigQuery native workarounds #535

Merged

Conversation

jamesnetherton
Copy link
Contributor

No description provided.

@jamesnetherton jamesnetherton force-pushed the remove-native-bigquery-workaround branch from 2af8717 to efedb16 Compare November 30, 2023 07:54
@jamesnetherton jamesnetherton changed the title Revert BigQuary native workarounds Revert BigQuery native workarounds Nov 30, 2023
@loicmathieu
Copy link
Collaborator

@jamesnetherton for the record can you link to an issue at Google Library side that fixes the issue upstream?

@jamesnetherton
Copy link
Contributor Author

@jamesnetherton for the record can you link to an issue at Google Library side that fixes the issue upstream?

@loicmathieu I believe it's this:

googleapis/sdk-platform-java#1344

Do you want me to reference it in the commit comment?

@loicmathieu
Copy link
Collaborator

Thanks for the info, it's OK for me.

Copy link
Collaborator

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loicmathieu loicmathieu merged commit dabbc6a into quarkiverse:main Nov 30, 2023
1 check passed
@jamesnetherton jamesnetherton deleted the remove-native-bigquery-workaround branch November 30, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants