Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

678: register Severity enum for reflection #679

Conversation

wabrit
Copy link
Contributor

@wabrit wabrit commented Sep 24, 2024

Register Severity enum for reflection so native app builds don't need to do this themselves. This addresses issue 678.

This has been tested by native building a Quarkus app and verifying that the correct severity levels appear in the GCP logging console.

Copy link
Collaborator

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot

@loicmathieu
Copy link
Collaborator

@all-contributors please add @wabrit for code

Copy link
Contributor

@loicmathieu

I've put up a pull request to add @wabrit! 🎉

@loicmathieu loicmathieu merged commit 5e4c646 into quarkiverse:main Sep 24, 2024
1 check passed
@wabrit wabrit deleted the issue-678-logging-register-enum-for-reflection branch September 24, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants