Merge pull request #604 from quarkiverse/#602

Add default values for URLS of HuggingFace models
quarkiverse · May 20, 2024 · 1f1e5b4 · 1f1e5b4
2 parents 3cd2bd5 + 96a97f9
commit 1f1e5b4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/...ime/src/main/java/io/quarkiverse/langchain4j/huggingface/QuarkusHuggingFaceChatModel.java b/...ime/src/main/java/io/quarkiverse/langchain4j/huggingface/QuarkusHuggingFaceChatModel.java
@@ -22,6 +22,7 @@
 import dev.langchain4j.model.huggingface.client.TextGenerationResponse;
 import dev.langchain4j.model.huggingface.spi.HuggingFaceClientFactory;
 import dev.langchain4j.model.output.Response;
+import io.quarkiverse.langchain4j.huggingface.runtime.config.ChatModelConfig;
 
 /**
  * This is a Quarkus specific version of the HuggingFace model.
@@ -121,7 +122,7 @@ public static final class Builder {
         private Integer maxNewTokens;
         private Boolean returnFullText;
         private Boolean waitForModel = true;
-        private URI url;
+        private URI url = URI.create(ChatModelConfig.DEFAULT_INFERENCE_ENDPOINT);
         private Optional<Boolean> doSample;
 
         private OptionalInt topK;

diff --git a/...rc/main/java/io/quarkiverse/langchain4j/huggingface/QuarkusHuggingFaceEmbeddingModel.java b/...rc/main/java/io/quarkiverse/langchain4j/huggingface/QuarkusHuggingFaceEmbeddingModel.java
@@ -15,6 +15,7 @@
 import dev.langchain4j.model.huggingface.client.HuggingFaceClient;
 import dev.langchain4j.model.huggingface.spi.HuggingFaceClientFactory;
 import dev.langchain4j.model.output.Response;
+import io.quarkiverse.langchain4j.huggingface.runtime.config.EmbeddingModelConfig;
 
 /**
  * This is a Quarkus specific version of the HuggingFace model.
@@ -81,7 +82,7 @@ public static final class Builder {
         private String accessToken;
         private Duration timeout = Duration.ofSeconds(15);
         private Boolean waitForModel = true;
-        private URI url;
+        private URI url = URI.create(EmbeddingModelConfig.DEFAULT_INFERENCE_ENDPOINT_EMBEDDING);
 
         public Builder accessToken(String accessToken) {
             this.accessToken = accessToken;