Merge pull request #868 from jpohlmeyer/fix-tool-required-param

Evaluate 'required' attribute of @p annotation in tool for optional parameters.
quarkiverse · Sep 11, 2024 · 6af9cba · 6af9cba
2 parents 4a9c1a3 + ef73477
commit 6af9cba
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/core/deployment/src/main/java/io/quarkiverse/langchain4j/deployment/ToolProcessor.java b/core/deployment/src/main/java/io/quarkiverse/langchain4j/deployment/ToolProcessor.java
@@ -203,7 +203,14 @@ public void handleTools(CombinedIndexBuildItem indexBuildItem,
                             memoryIdParameter = parameter;
                             continue;
                         }
-                        builder.addParameter(parameter.name(), toJsonSchemaProperties(parameter, index));
+
+                        AnnotationInstance pInstance = parameter.annotation(P);
+                        if (pInstance != null && pInstance.value("required") != null
+                                && !pInstance.value("required").asBoolean()) {
+                            builder.addOptionalParameter(parameter.name(), toJsonSchemaProperties(parameter, index));
+                        } else {
+                            builder.addParameter(parameter.name(), toJsonSchemaProperties(parameter, index));
+                        }
                     }
 
                     Map<String, Integer> nameToParamPosition = toolMethod.parameters().stream().collect(