Merge pull request #379 from jmartisk/issue-329-milvus

Use the MilvusContainer from testcontainers
quarkiverse · Mar 15, 2024 · 76e6113 · 76e6113
2 parents 5b336f9 + c16f72c
commit 76e6113
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 253 deletions.
diff --git a/milvus/deployment/pom.xml b/milvus/deployment/pom.xml
@@ -31,6 +31,10 @@
             <groupId>io.quarkus</groupId>
             <artifactId>quarkus-devservices-deployment</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.testcontainers</groupId>
+            <artifactId>milvus</artifactId>
+        </dependency>
         <dependency>
             <groupId>dev.langchain4j</groupId>
             <artifactId>langchain4j-core</artifactId>

diff --git a/milvus/deployment/src/main/java/io/quarkiverse/langchain4j/milvus/MilvusBuildConfig.java b/milvus/deployment/src/main/java/io/quarkiverse/langchain4j/milvus/MilvusBuildConfig.java
@@ -30,21 +30,9 @@ interface MilvusDevServicesBuildTimeConfig {
         /**
          * Container image for Milvus.
          */
-        @WithDefault("docker.io/milvusdb/milvus:v2.3.3")
+        @WithDefault("docker.io/milvusdb/milvus:v2.3.4")
         String milvusImageName();
 
-        /**
-         * Container image for etcd.
-         */
-        @WithDefault("quay.io/coreos/etcd:v3.5.5")
-        String etcdImageName();
-
-        /**
-         * Container image for minio.
-         */
-        @WithDefault("docker.io/minio/minio:RELEASE.2023-12-13T23-28-55Z")
-        String minioImageName();
-
         /**
          * Optional fixed port the Milvus dev service will listen to.
          * If not defined, the port will be chosen randomly.