Eliminate BeanXProviderSupplier

[cescoffier]

Discovering this value is hard. Adding the implementation class name might be simpler.

[geoand]

Discovering this value is hard

I agree.

Adding the implementation class name might be simpler.

You mean allowing the user to just add the class name they want to be used?

[cescoffier]

I believe it would be simpler if the user can just write:

@RegisterAiService(retriever=TheClassNameOfMyBean.class)

[geoand]

I like the idea.

I'm thinking that by specifying the class we can look it up via CDI is just fallback to a no-args constructor if there is no bean.
I'll have a look some time this week.

[geoand]

I was thinking of this, and I have a new proposal:

What if we keep what we have now, but change the default to something like: BeanIfExistsChatMemoryProviderSupplier which would automatically use the bean if it exists, but would not fail it no bean exists and would just not use any memory.

WDYT?

[cescoffier]

That works! The next issue is: what would be the value when you have multiple retrievers and you want to select one. The retriever is not a supplier, just a plain implementation of the retriever. I think Suppliers are used as factories. However in our case, the scope is what define when to create the instance.

…

On Wed 22 Nov 2023 at 07:44, Georgios Andrianakis ***@***.***> wrote: I was thinking of this, and I have a new proposal: What if we keep what we have now, but change the default to something like: BeanIfExistsChatMemoryProviderSupplier which would automatically use the bean if it exists, but would not fail it no bean exists and would just not use any memory. WDYT? — Reply to this email directly, view it on GitHub <#43 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADCG7MPROEOALUQTRSPCKTYFWNOVAVCNFSM6AAAAAA7SVBIL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRSGIYDANRYGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[geoand]

I think Suppliers are used as factories

Yeah, that was my intention. If users want more advanced ways of choosing an implementation, then it's up to them to write the supplier.

[geoand]

#51 should take care of it