Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the need to explicitly configure retriever and memory beans for @RegisterAiService #51

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Remove the need to explicitly configure retriever and memory beans for @RegisterAiService #51

merged 2 commits into from
Nov 22, 2023

Conversation

geoand
Copy link
Collaborator

@geoand geoand commented Nov 22, 2023

Closes: #43

@geoand geoand requested a review from a team as a code owner November 22, 2023 08:02
@geoand geoand mentioned this pull request Nov 22, 2023
Closed
cescoffier
cescoffier requested changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc should be updated too.

@geoand
Copy link
Collaborator Author

geoand commented Nov 22, 2023

The doc should be updated too.

Done

@geoand geoand requested a review from cescoffier November 22, 2023 08:20
@cescoffier cescoffier merged commit 4c291c9 into main Nov 22, 2023
2 checks passed
@cescoffier cescoffier deleted the aiservices-beans branch November 22, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier Awaiting requested review from cescoffier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eliminate BeanXProviderSupplier
2 participants
@geoand @cescoffier