Easy-rag: allow to specify minScore through configuration #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartisk
approved these changes
Oct 31, 2024
|
I was debating whether to set a default of 0.0 (the current LangChain4j default), or to make it an OptionalDouble and only set it if the user wants it, that way if upstream LangChain4j changed the default then we would just inherit their default, rather than always say 0.0 |
edeandrea
force-pushed
the
easy-rag-add-min-score
branch
from
d9c3552 to
80003ee
Compare
|
Just rebased based on #1027 (comment) |
edeandrea
force-pushed
the
easy-rag-add-min-score
branch
from
01044b3 to
51d8cea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing to specify
minScorethrough configuration.Also a little refactoring to pass the whole
EasyRagConfiginto theEasyRetrievalAugmentorrather than just themaxResults