Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.21.0.CR3 #1031

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Release 0.21.0.CR3 #1031

merged 1 commit into from
Nov 1, 2024

Conversation

geoand
Copy link
Collaborator

@geoand geoand commented Nov 1, 2024

No description provided.

@geoand geoand requested a review from a team as a code owner November 1, 2024 08:11
@geoand geoand merged commit 91f06e7 into main Nov 1, 2024
2 checks passed
@geoand geoand deleted the release-0.21.0.CR3 branch November 1, 2024 08:12
@geoand
Copy link
Collaborator Author

geoand commented Nov 1, 2024

@gastaldi I want to perform some post release steps so I did https://github.com/quarkiverse/quarkus-langchain4j/blob/main/.github/workflows/release-perform.yml#L22-L43

However I don't see those post release steps having taken place. Any idea what I'm doing wrong?

@geoand
Copy link
Collaborator Author

geoand commented Nov 1, 2024

Actually, the whole release probably failed completely...
But I don't have access the action that ran, so I don't know really

@gastaldi
Copy link
Member

gastaldi commented Nov 1, 2024

You need to put in a different job, not steps

@geoand
Copy link
Collaborator Author

geoand commented Nov 1, 2024

Makes sense.

That leaves the question of how I can see the action logs when something goes wrong :)

@gastaldi
Copy link
Member

gastaldi commented Nov 1, 2024

I see it fails here because the YAML is invalid: https://github.com/quarkiverse/quarkus-langchain4j/actions/runs/11626863204

@geoand
Copy link
Collaborator Author

geoand commented Nov 1, 2024

Ah, I missed that, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants